Attention is currently required from: jolly.

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )

Change subject: Add Cisco like DSCP configuration support ......................................................................

Patch Set 2:

(25 comments)

File src/ss7_qos_class.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/fcfee316_b2d844... : PS2, Line 10: struct llist_head list; code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/a420d5c2_480a86... : PS2, Line 10: struct llist_head list; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/f09f50e5_c194c8... : PS2, Line 11: struct osmo_ss7_instance *inst; code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/93624ba1_6b9e29... : PS2, Line 11: struct osmo_ss7_instance *inst; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b7b7bda4_7d286d... : PS2, Line 13: uint8_t qos_class; code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/70b5e406_09557f... : PS2, Line 13: uint8_t qos_class; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/35863125_fb19d6... : PS2, Line 14: uint8_t ip_dscp; code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/a89a7e6a_22b81c... : PS2, Line 14: uint8_t ip_dscp; please, no spaces at the start of a line

File src/ss7_qos_class_vty.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/363c2ad0_83ebe3... : PS2, Line 56: vty->index = qos; code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/2b20d2f3_8645a0... : PS2, Line 56: vty->index = qos; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/f44e0f9d_41825e... : PS2, Line 84: "qos-ip-dscp " IP_DSCP_RANGE_STR, code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/7bf1f5ff_c38691... : PS2, Line 84: "qos-ip-dscp " IP_DSCP_RANGE_STR, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/8272d9dd_cd8681... : PS2, Line 85: "Specify IP DSCP of QoS class\n" code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/affd3f16_4ef96d... : PS2, Line 85: "Specify IP DSCP of QoS class\n" please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/3f661bfe_cda39a... : PS2, Line 86: IP_DSCP_RANGE_HELP_STR, code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/798746d5_aff062... : PS2, Line 86: IP_DSCP_RANGE_HELP_STR, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/14c272f2_0f0f5f... : PS2, Line 87: CMD_ATTR_NODE_EXIT) code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/29f22fcc_7640f3... : PS2, Line 87: CMD_ATTR_NODE_EXIT) please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/778ecb23_0c9597... : PS2, Line 98: "no qos-ip-dscp", code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/d2843dd8_530f57... : PS2, Line 98: "no qos-ip-dscp", please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b65e4606_b8ecb5... : PS2, Line 99: NO_STR "Reset IP DSCP of QoS class to default\n", code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/838fa806_d3c15f... : PS2, Line 99: NO_STR "Reset IP DSCP of QoS class to default\n", please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/1ed8c9bc_8ab20b... : PS2, Line 100: CMD_ATTR_NODE_EXIT) code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/03cda8c9_5ad7ed... : PS2, Line 100: CMD_ATTR_NODE_EXIT) please, no spaces at the start of a line

File src/ss7_vty.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/ecde16a5_5f8cc2... : PS2, Line 1446: vty->index = qos->inst; code indent should use tabs where possible