Attention is currently required from: jolly.

View Change

25 comments:

• File src/ss7_qos_class.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 10: struct llist_head list;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 10: struct llist_head list;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 11: struct osmo_ss7_instance *inst;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 11: struct osmo_ss7_instance *inst;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 13: uint8_t qos_class;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 13: uint8_t qos_class;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 14: uint8_t ip_dscp;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 14: uint8_t ip_dscp;

    please, no spaces at the start of a line

• File src/ss7_qos_class_vty.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 56: vty->index = qos;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 56: vty->index = qos;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 84: "qos-ip-dscp " IP_DSCP_RANGE_STR,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 84: "qos-ip-dscp " IP_DSCP_RANGE_STR,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 85: "Specify IP DSCP of QoS class\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 85: "Specify IP DSCP of QoS class\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 86: IP_DSCP_RANGE_HELP_STR,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 86: IP_DSCP_RANGE_HELP_STR,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 87: CMD_ATTR_NODE_EXIT)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 87: CMD_ATTR_NODE_EXIT)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 98: "no qos-ip-dscp",

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 98: "no qos-ip-dscp",

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 99: NO_STR "Reset IP DSCP of QoS class to default\n",

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 99: NO_STR "Reset IP DSCP of QoS class to default\n",

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 100: CMD_ATTR_NODE_EXIT)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 100: CMD_ATTR_NODE_EXIT)

    please, no spaces at the start of a line

• File src/ss7_vty.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 1446: vty->index = qos->inst;

    code indent should use tabs where possible

To view, visit change 43667. To unsubscribe, or for help writing mail filters, visit settings.