msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28992 ) Change subject: Add osmo_sockaddr_strs_to_str() ...................................................................... Patch Set 6: (2 comments) This change is ready for review. File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/b3f3fbbf_eca393d8 PS6, Line 565: ret = snprintf(buf, rem, "(");

FYI, you can have a look at using OSMO_STRBUF APIs, they are useful to implement stuff like done in […] Ack

https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/42ba2792_bc6fe26a PS6, Line 578: OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]), after);

maybe add a boolean print_ports to decide whether to add ports or not? Good idea, although it's better to do so in the caller of this function.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89 Gerrit-Change-Number: 28992 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 12 Aug 2022 10:53:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment