View Change

2 comments:

• File src/sockaddr_str.c:

  • Patch Set #6, Line 565: ret = snprintf(buf, rem, "(");

    FYI, you can have a look at using OSMO_STRBUF APIs, they are useful to implement stuff like done in […]

    Ack

  • Patch Set #6, Line 578: OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]), after);

    maybe add a boolean print_ports to decide whether to add ports or not?

    Good idea, although it's better to do so in the caller of this function.

To view, visit change 28992. To unsubscribe, or for help writing mail filters, visit settings.