Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email ) Change subject: Add functions to events from server to client ...................................................................... Patch Set 1: (1 comment) File src/e1d.h: https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/1db90444_c485d8e0 PS1, Line 199: void *srv;

I don't see this used in this patch ? Ok, I see it used in further patches, but then I'd use the proper type struct osmo_e1dp_server.

Also not sure this belongs in this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e Gerrit-Change-Number: 35558 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 18:25:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt@246tNt.com> Gerrit-MessageType: comment