Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35559?usp=email ) Change subject: Indicate framing alignment error as alarm inidication signal ...................................................................... Patch Set 1: (1 comment) File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/35559/comment/c9892641_0a00fb20 PS1, Line 401: if ((errcnt->flags & ICE1USB_ERR_F_ALIGN_ERR)) { I might be misremembering but that's not AIS AIS is we receive an Alarm Indicator Signal from the far-end (all 1s) This error flag is our local end has lost framing. Which granted would happen if we received an AIS but it also happens if we get garbage. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaad3adb6afb9e1d8a002fa4a04ba4ab8e51671a3 Gerrit-Change-Number: 35559 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 18:31:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment