Change in osmo-ci[master]: lint: ignore MACRO_WITH_FLOW_CONTROL
Attention is currently required from: neels, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29359 ) Change subject: lint: ignore MACRO_WITH_FLOW_CONTROL ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1:
i have made one too, OSMO_NAME_C_IMPL(), but still i think it's ok to let the linter complain about […] I think the linter is most useful if it only complains in clear cases of something done wrong, otherwise it becomes annoying for users IMHO. I see it complain about this and then getting overridden a lot, so therefore I think it makes sense to just ignore this check. Similar to how in theory we have a line limit of 120 characters in our coding guidelines, but also break that so often that automatically checking for it would be annoying.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79da5a426db59031e3b16aecedeaa1498c91e847 Gerrit-Change-Number: 29359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 19 Sep 2022 08:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
osmith