Attention is currently required from: neels, laforge.

Patch set 1:Code-Review +2

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    i have made one too, OSMO_NAME_C_IMPL(), but still i think it's ok to let the linter complain about […]

    I think the linter is most useful if it only complains in clear cases of something done wrong, otherwise it becomes annoying for users IMHO. I see it complain about this and then getting overridden a lot, so therefore I think it makes sense to just ignore this check. Similar to how in theory we have a line limit of 120 characters in our coding guidelines, but also break that so often that automatically checking for it would be annoying.

To view, visit change 29359. To unsubscribe, or for help writing mail filters, visit settings.