Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31155 ) Change subject: common: Fix memleak in get_smscb_block() ...................................................................... Patch Set 6: (2 comments) File src/common/cbch.c: https://gerrit.osmocom.org/c/osmo-bts/+/31155/comment/04347550_1a09e228 PS5, Line 142: block_type->lb = block_nr + 1 == msg->num_segs;

Lots of missing parenthesis here, I first thought you were doing double assignment. Done. So the linter should be updated then, I'm not getting a warning with the current one from `osmo-ci`

https://gerrit.osmocom.org/c/osmo-bts/+/31155/comment/7b62d79a_30267e2f PS5, Line 150: } else

you must keep {} in "else" if the "if" block has {} (coding style). alright I'll keep it in mind from now on.. so it's beauty over brevity in this case

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dc116d6c16c80b31712b2a969f0b2a6998b03f0 Gerrit-Change-Number: 31155 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 18:58:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment