Attention is currently required from: pespin.

View Change

2 comments:

• File src/common/cbch.c:

  • Patch Set #5, Line 142: block_type->lb = block_nr + 1 == msg->num_segs;

    Lots of missing parenthesis here, I first thought you were doing double assignment.

    Done. So the linter should be updated then, I'm not getting a warning with the current one from `osmo-ci`

  • Patch Set #5, Line 150: } else

    you must keep {} in "else" if the "if" block has {} (coding style).

    alright I'll keep it in mind from now on.. so it's beauty over brevity in this case

To view, visit change 31155. To unsubscribe, or for help writing mail filters, visit settings.