Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31623 ) Change subject: Introduce debian-bullseye-titan-master ...................................................................... Patch Set 1: (7 comments) File debian-bullseye-titan-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/bcc6f848_ca8e... PS1, Line 32: Install titan.core dependencies How about using `apt-get build-dep` for that? This way we [hopefully] always install all dependencies, which may be added by the upstream any time. This is what we do for `open5gs-master`. https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/645aa82f_3f83... PS1, Line 74: j8 `$nproc`? https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/6571a813_6bb0... PS1, Line 84: Debian folks updated the gcc version but not titan Is this still relevant when building titan from source? https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/5c151fc5_ad8a... PS1, Line 94: wget Why not using Docker's `ADD` here to fetch a file? The benefit of using it is that the cache will be invalidated automatically when a new version of `libfftranscode` is available on the server. Also, I suggest making the lib version configurable via an environment variable, so that it's easier to upgrade if needed. File debian-bullseye-titan-master/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/290cb100_ad75... PS1, Line 1: ../debian-bullseye-titan/Makefile "No newline at end of right file." File debian-bullseye-titan-master/ttcn3-docker-prepare.sh: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/a41f91df_8fbc... PS1, Line 1: #!/bin/sh -e Might be a good idea to move this file to `common/` and `ADD` it from there, to avoid code duplication. Stuff like `respawn.sh` and `Release.key` is already there. File debian-bullseye-titan-master/ttcn3-docker-run.sh: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/c5358b3c_f137... PS1, Line 1: #!/bin/bash Same here, move this file to `common/`. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19ee98a319ccad167d06c4f183fe80ecac909483 Gerrit-Change-Number: 31623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 01 Mar 2023 20:41:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment