Attention is currently required from: pespin.
7 comments:
File debian-bullseye-titan-master/Dockerfile:
Patch Set #1, Line 32: Install titan.core dependencies
How about using `apt-get build-dep` for that? This way we [hopefully] always install all dependencies, which may be added by the upstream any time. This is what we do for `open5gs-master`.
`$nproc`?
Patch Set #1, Line 84: Debian folks updated the gcc version but not titan
Is this still relevant when building titan from source?
Why not using Docker's `ADD` here to fetch a file? The benefit of using it is that the cache will be invalidated automatically when a new version of `libfftranscode` is available on the server. Also, I suggest making the lib version configurable via an environment variable, so that it's easier to upgrade if needed.
File debian-bullseye-titan-master/Makefile:
Patch Set #1, Line 1: ../debian-bullseye-titan/Makefile
"No newline at end of right file."
File debian-bullseye-titan-master/ttcn3-docker-prepare.sh:
Patch Set #1, Line 1: #!/bin/sh -e
Might be a good idea to move this file to `common/` and `ADD` it from there, to avoid code duplication. Stuff like `respawn.sh` and `Release.key` is already there.
File debian-bullseye-titan-master/ttcn3-docker-run.sh:
Patch Set #1, Line 1: #!/bin/bash
Same here, move this file to `common/`.
To view, visit change 31623. To unsubscribe, or for help writing mail filters, visit settings.