Attention is currently required from: daniel, lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )

Change subject: GMM: split parsing of a RA Update Request in a separate file ......................................................................

Patch Set 5:

(4 comments)

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/018b4518_74f268f2?usp... : PS5, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type);

Use %d instead of %i

Please fix.

File src/sgsn/gprs_gmm_util.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/625581be_3ecbe9d0?usp... : PS5, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg))))

that open brace { should be on the previous line

Please fix.

https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/5228b622_b4120833?usp... : PS5, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) {

braces {} are not necessary for single statement blocks

Please fix.

https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/98ae620e_c3b7d523?usp... : PS5, Line 115: if (ret < 0) {

braces {} are not necessary for single statement blocks

Please fix.