Attention is currently required from: daniel, lynxis lazus.

View Change

4 comments:

• File src/sgsn/gprs_gmm.c:

  • Patch Set #5, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type);

    Use %d instead of %i

    Please fix.

• File src/sgsn/gprs_gmm_util.c:

  • Patch Set #5, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg))))

    that open brace { should be on the previous line

    Please fix.

  • Patch Set #5, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) {

    braces {} are not necessary for single statement blocks

    Please fix.

  • Patch Set #5, Line 115: if (ret < 0) {

    braces {} are not necessary for single statement blocks

    Please fix.

To view, visit change 37869. To unsubscribe, or for help writing mail filters, visit settings.