Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email ) Change subject: Add a GSM RLP decoder and encoder ...................................................................... Patch Set 7: Code-Review+1 (5 comments) File include/osmocom/gsm/rlp.h: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/43745dd9_8d966336 PS4, Line 1: /* maybe add a line description here pointing to 3GPP TS 24.022. https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/a0662805_123e8682 PS4, Line 24: /*! \defgroup rlp GSM RLP (Radio Link Protocol) as used in CSD or add reference to 3GPP TS 24.022 here. File src/gsm/rlp.c: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/cbbe0d00_55136812 PS4, Line 85: //out->fcs = (data[240/8-3] << 16) | (data[240/8-2]) << 8 | (data[240/8-1] << 0); this line can be dropped? https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/a80da4e4_66321f8e PS4, Line 89: if (n_s == 0x3f) { switch (n_s) https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/65a68dbd_5bfbaed0 PS4, Line 93: memcpy(out->info, data+2, 240/8 - 5); This 240/8 appears a lot of times, it may be worth describing it in a define. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d9bd8eb4f0cd0f72c436996767b199429596917 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 16:35:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment