Attention is currently required from: fixeria, laforge, osmith.

Patch set 7:Code-Review +1

View Change

5 comments:

• File include/osmocom/gsm/rlp.h:

  • Patch Set #4, Line 1: /*

    maybe add a line description here pointing to 3GPP TS 24.022.

  • Patch Set #4, Line 24: /*! \defgroup rlp GSM RLP (Radio Link Protocol) as used in CSD

    or add reference to 3GPP TS 24.022 here.

• File src/gsm/rlp.c:

  • Patch Set #4, Line 85: //out->fcs = (data[240/8-3] << 16) | (data[240/8-2]) << 8 | (data[240/8-1] << 0);

    this line can be dropped?

  • Patch Set #4, Line 89: if (n_s == 0x3f) {

    switch (n_s)

  • Patch Set #4, Line 93: memcpy(out->info, data+2, 240/8 - 5);

    This 240/8 appears a lot of times, it may be worth describing it in a define.

To view, visit change 35123. To unsubscribe, or for help writing mail filters, visit settings.