neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28233 ) Change subject: tweak comments in rua_to_scu() ...................................................................... tweak comments in rua_to_scu() Change-Id: I227a5e6b869da453fa72ff0eebaa1e95aa9625e6 --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 00ac09e..e4f345e 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -264,13 +264,15 @@ return -EINVAL; } - /* add optional data section, if needed */ + /* If there is RANAP data, include it in the msgb. Usually there is data, but this could also be an SCCP CR + * a.k.a. OSMO_SCU_PRIM_N_CONNECT without RANAP payload. */ if (data && len) { msg->l2h = msgb_put(msg, len); memcpy(msg->l2h, data, len); } - /* Intercept RAB Assignment Response, inform MGW FSM. */ + /* If there is data, see if it is a RAB Assignment message where we need to change the user plane information, + * for RTP mapping via MGW (soon also GTP mapping via UPF). */ if (data && len && map && !map->is_ps && !release_context_map) { message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I227a5e6b869da453fa72ff0eebaa1e95aa9625e6 Gerrit-Change-Number: 28233 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged