neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28232 ) Change subject: allow calling rua_to_scu() without data ...................................................................... allow calling rua_to_scu() without data There can be SCCP primitives without payload data, e.g. an "empty" SCCP Connection Request. Patch 'mgw_fsm: add MGW support to osmo-hnbgw' added RANAP message decoding that lacks a guard against NULL data. Fix that: do not try to decode NULL data. Related: SYS#5968 Change-Id: Id755e769e82ace7203460ea1b3c847c2c90d41bf --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 1943ac0..00ac09e 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -271,7 +271,7 @@ } /* Intercept RAB Assignment Response, inform MGW FSM. */ - if (map && !map->is_ps && !release_context_map) { + if (data && len && map && !map->is_ps && !release_context_map) { message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id755e769e82ace7203460ea1b3c847c2c90d41bf Gerrit-Change-Number: 28232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged