[M] Change in osmo-remsim[master]: Add maintenance mapping support to osmo-remsim-server
Attention is currently required from: jolly, laforge, lynxis lazus. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email ) Change subject: Add maintenance mapping support to osmo-remsim-server ...................................................................... Patch Set 6: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/d8c29739_de58a633?u... : PS6, Line 15: mapping, the normal mapping is suspended. The maintenance mapping hat mappings wearing hats is nice, but I guess you meant: "The maintenance mapping *has* priority over the *normal* mapping" https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/f3faaa17_61f0b35a?u... : PS6, Line 16: priority over the mapping. The following steps are performed: The following steps are perfomed when? which scenario? https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/2adcbfd0_019b2d2f?u... : PS6, Line 19: * The normal mapping is deleted and put into INACTIVE state. how can it be deleted then put into INACTIVE? deletion means doesn't exist anymore right? File src/server/rest_api.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/46bd92bc_6d17f08a?u... : PS6, Line 373: /* If we are suspended an exisisting mapping, we stay inactive until the mapping was removed. */ Rephrase this sentence, it has at least a couple wrong grammar issues regarding verb tenses which makes it difficult to understand (I really don't get it). File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/1d808d17_30b81f51?u... : PS6, Line 438: if (map->suspend) { can we rename this to "suspend_requested" or similar? the "suspend" naming is a bit confusing on what it actually means. In here it seems to mean that a suspend has been requested but the thing is not yet suspended, while in line 459 it seems to indicate it was already suspended? File src/slotmap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/c8d7cbcb_e12b396a?u... : PS6, Line 65: /* this mapping is (to be) suspended */ Ok, so it can actually mean 2 different things, which is actually quite confusing ;) if this flag is set, how to know if it is already suspended or not yet? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I885b3b529276f46fbbe6d86be2170b0bffbb8434 Gerrit-Change-Number: 43745 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 11 Nov 2026 10:55:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
pespin