Attention is currently required from: jolly, laforge, lynxis lazus.
6 comments:
Commit Message:
Patch Set #6, Line 15: mapping, the normal mapping is suspended. The maintenance mapping hat
mappings wearing hats is nice, but I guess you meant: "The maintenance mapping *has* priority over the *normal* mapping"
Patch Set #6, Line 16: priority over the mapping. The following steps are performed:
The following steps are perfomed when? which scenario?
Patch Set #6, Line 19: * The normal mapping is deleted and put into INACTIVE state.
how can it be deleted then put into INACTIVE? deletion means doesn't exist anymore right?
File src/server/rest_api.c:
Patch Set #6, Line 373: /* If we are suspended an exisisting mapping, we stay inactive until the mapping was removed. */
Rephrase this sentence, it has at least a couple wrong grammar issues regarding verb tenses which makes it difficult to understand (I really don't get it).
File src/server/rspro_server.c:
Patch Set #6, Line 438: if (map->suspend) {
can we rename this to "suspend_requested" or similar? the "suspend" naming is a bit confusing on what it actually means.
In here it seems to mean that a suspend has been requested but the thing is not yet suspended, while in line 459 it seems to indicate it was already suspended?
File src/slotmap.h:
Patch Set #6, Line 65: /* this mapping is (to be) suspended */
Ok, so it can actually mean 2 different things, which is actually quite confusing ;)
if this flag is set, how to know if it is already suspended or not yet?
To view, visit change 43745. To unsubscribe, or for help writing mail filters, visit settings.