Attention is currently required from: jolly, laforge, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email )

Change subject: Add logging category for libosmo-cc ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File include/osmocom/core/logging.h:

https://gerrit.osmocom.org/c/libosmocore/+/35572/comment/438c1216_fe043e10 PS2, Line 158: #defin

this breaks ABI

I am wondering about potential consequences. Obviously, adding a new category here enlarges the `internal_cat[]` array. I assumed that this might result in logging categories being shifted and thus messed up in the logging output, but this does not seem to be the case if I understand the logic in `log_init()` correctly. It would first copy the user-supplied logging categories, and only then copy the internal ones from `internal_cat[]`.

So even if some application was compiled against an older version of libosmocore predating this commit, I don't see how a more recent libosmocore with DLCC would break logging in that application. Unless I am missing something, I think it should be fine to merge this commit as-is.