Attention is currently required from: jolly, laforge, pespin.

Patch set 3:Code-Review +1

View Change

1 comment:

• File include/osmocom/core/logging.h:

  • Patch Set #2, Line 158: #defin

    this breaks ABI

    I am wondering about potential consequences. Obviously, adding a new category here enlarges the `internal_cat[]` array. I assumed that this might result in logging categories being shifted and thus messed up in the logging output, but this does not seem to be the case if I understand the logic in `log_init()` correctly. It would first copy the user-supplied logging categories, and only then copy the internal ones from `internal_cat[]`.

    So even if some application was compiled against an older version of libosmocore predating this commit, I don't see how a more recent libosmocore with DLCC would break logging in that application. Unless I am missing something, I think it should be fine to merge this commit as-is.

To view, visit change 35572. To unsubscribe, or for help writing mail filters, visit settings.