Attention is currently required from: fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32985 )

Change subject: rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2 ......................................................................

Patch Set 2:

(3 comments)

File src/rlcmac/rlcmac.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/506c7d79_90d94fa7 PS2, Line 338: struct gsm48_paging1 *pag

const?

Ack

https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/c8681a1e_8419df67 PS2, Line 352: if (GSM_MACBLOCK_LEN < sizeof(*pag))

Not sure why would you want to check this at run-time. […]

that's from previous code where GSM_MACBLOCK_LEN used to be msgb_l3len(msg), I'll drop it.

https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/2961e814_7008e807 PS2, Line 363: if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1)

Same here, `sizeof(*pag)` does not change at run-time, right?

same.