Attention is currently required from: fixeria.

View Change

3 comments:

• File src/rlcmac/rlcmac.c:

  • Patch Set #2, Line 338: struct gsm48_paging1 *pag

    const?

    Ack

  • Patch Set #2, Line 352: if (GSM_MACBLOCK_LEN < sizeof(*pag))

    Not sure why would you want to check this at run-time. […]

    that's from previous code where GSM_MACBLOCK_LEN used to be msgb_l3len(msg), I'll drop it.

  • Patch Set #2, Line 363: if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1)

    Same here, `sizeof(*pag)` does not change at run-time, right?

    same.

To view, visit change 32985. To unsubscribe, or for help writing mail filters, visit settings.