Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: add IPv6 support ...................................................................... Patch Set 1: (4 comments) File include/linux/gtp.h: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/909c69a6_2fe7781a PS1, Line 27: #define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */ I'm not sure I'm following here. I don't see this GTPA_SGSN_ADDRESS being defined previously, hence not sure which legacy attr you talk about. If you would like to maintain legacy of GTPA_PEER_ADDRESS, I'd write it the other way: GTPA_SGSN_ADDRESS, #define GTPA_PEER_ADDRESS GTPA_SGSN_ADDRESS /* maintain legacy attr name */ File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/1f2861a8_72d678fb PS1, Line 60: mnl_attr_put(nlh, GTPA_PEER_ADDR6, sizeof(t->ip6.sgsn_addr), &t->ip6.sgsn_addr); why do we check for ANY_ADDR in ipv4 but not in ipv6? https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/430ba8c9_55dae7cb PS1, Line 220: } "default: return MNL_CB_ERROR;" ? File src/gtp.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/d688434b_f7cf4aec PS1, Line 39: t->family = AF_INET; explain here with a comment that you add this here to maintain backward compat with older apps. -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Fri, 13 Oct 2023 11:26:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment