Attention is currently required from: osmith.

View Change

4 comments:

• File include/linux/gtp.h:

  • Patch Set #1, Line 27: #define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */

    I'm not sure I'm following here. I don't see this GTPA_SGSN_ADDRESS being defined previously, hence not sure which legacy attr you talk about.

    If you would like to maintain legacy of GTPA_PEER_ADDRESS, I'd write it the other way:
    GTPA_SGSN_ADDRESS,
    #define GTPA_PEER_ADDRESS GTPA_SGSN_ADDRESS /* maintain legacy attr name */

• File src/gtp-genl.c:

  • Patch Set #1, Line 60: mnl_attr_put(nlh, GTPA_PEER_ADDR6, sizeof(t->ip6.sgsn_addr), &t->ip6.sgsn_addr);

    why do we check for ANY_ADDR in ipv4 but not in ipv6?

  • Patch Set #1, Line 220: }

    "default: return MNL_CB_ERROR;" ?

• File src/gtp.c:

  • Patch Set #1, Line 39: t->family = AF_INET;

    explain here with a comment that you add this here to maintain backward compat with older apps.

To view, visit change 34735. To unsubscribe, or for help writing mail filters, visit settings.