Attention is currently required from: dexter, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email ) Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Patch Set 6: (3 comments) File host/tests/apdu_dispatch/apdu_dispatch_test.c: https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/70138950_0b847ed7?usp... : PS3, Line 18: memset(&prev_ac, 0, sizeof(prev_ac)); \

prev_ac only appears in the memset and nowhere else, is this line needed in this macro? Done

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/e99c3e3f_c6e62f86?usp... : PS3, Line 22: printf("%d (actual) != %d (intended)\n", rc, exp_rc);\

I think (expected) is more accurate. The variable is also called "exp_rc". Done

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/0209f618_d0b3ca17?usp... : PS3, Line 55: rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_ca, ARRAY_SIZE(get_data_c2_ca), 1);

The last parameter of osmo_apdu_segment_in2 is a bool. […] Done

-- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Aug 2026 13:23:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de>