Attention is currently required from: dexter, laforge.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )

Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ......................................................................

Patch Set 6:

(3 comments)

File host/tests/apdu_dispatch/apdu_dispatch_test.c:

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/70138950_0b847ed7?usp... : PS3, Line 18: memset(&prev_ac, 0, sizeof(prev_ac)); \

prev_ac only appears in the memset and nowhere else, is this line needed in this macro?

Done

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/e99c3e3f_c6e62f86?usp... : PS3, Line 22: printf("%d (actual) != %d (intended)\n", rc, exp_rc);\

I think (expected) is more accurate. The variable is also called "exp_rc".

Done

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/0209f618_d0b3ca17?usp... : PS3, Line 55: rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_ca, ARRAY_SIZE(get_data_c2_ca), 1);

The last parameter of osmo_apdu_segment_in2 is a bool. […]

Done