Attention is currently required from: dexter, laforge.

View Change

3 comments:

• File host/tests/apdu_dispatch/apdu_dispatch_test.c:

  • Patch Set #3, Line 18: memset(&prev_ac, 0, sizeof(prev_ac)); \

    prev_ac only appears in the memset and nowhere else, is this line needed in this macro?

    Done

  • Patch Set #3, Line 22: printf("%d (actual) != %d (intended)\n", rc, exp_rc);\

    I think (expected) is more accurate. The variable is also called "exp_rc".

    Done

  • Patch Set #3, Line 55: rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_ca, ARRAY_SIZE(get_data_c2_ca), 1);

    The last parameter of osmo_apdu_segment_in2 is a bool. […]

    Done

To view, visit change 43185. To unsubscribe, or for help writing mail filters, visit settings.