Attention is currently required from: neels, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 ) Change subject: libosmo-pfcp: implement PFCP header and msg handling ...................................................................... Patch Set 7: Code-Review+1 (6 comments) File include/osmocom/pfcp/pfcp_msg.h: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/e36f6363_18669def PS3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \

you are aware of the "ARGS... […] Its also the first time we are reaching this kind of complexit in a log macro...

https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/135436b4_1ac02fa6 PS3, Line 110: struct osmo_fsm_inst *peer_fi;

if it is only related to a peer (Association Setup / Update, etc), session == NULL. […] Done

https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/64b42d4f_38b04b65 PS3, Line 123: #define OSMO_PFCP_MSG_FOR_IES(IES_P) ((struct osmo_pfcp_msg *)((char *)IES_P - offsetof(struct osmo_pfcp_msg, ies)))

there is the osmo_pfcp_msg->ies member. […] Done

https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/98ac6e6d_c9041b12 PS3, Line 149: #define OSMO_PFCP_MSG_MEMB(M, OFS) ((OFS) <= 0 ? NULL : (void *)((uint8_t *)(M) + OFS))

for example, some messages don't have a Cause IE. […] Done

File src/libosmo-pfcp/pfcp_msg.c: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/ab472590_93aa3bd5 PS3, Line 65: struct osmo_pfcp_header_common {

oh yes, forgot to run that script... Done

https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/ba14ab4d_475f7cfc PS3, Line 338: /* Append the encoded PFCP message to the message buffer.

It is a feature described in the PFCP specs. […] Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e Gerrit-Change-Number: 27631 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 07:04:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment