Attention is currently required from: neels, pespin, fixeria.

Patch set 7:Code-Review +1

View Change

6 comments:

• File include/osmocom/pfcp/pfcp_msg.h:

  • Patch Set #3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \

    you are aware of the "ARGS... […]

    Its also the first time we are reaching this kind of complexit in a log macro...

  • Patch Set #3, Line 110: struct osmo_fsm_inst *peer_fi;

    if it is only related to a peer (Association Setup / Update, etc), session == NULL. […]

    Done

  • Patch Set #3, Line 123: #define OSMO_PFCP_MSG_FOR_IES(IES_P) ((struct osmo_pfcp_msg *)((char *)IES_P - offsetof(struct osmo_pfcp_msg, ies)))

    there is the osmo_pfcp_msg->ies member. […]

    Done

  • Patch Set #3, Line 149: #define OSMO_PFCP_MSG_MEMB(M, OFS) ((OFS) <= 0 ? NULL : (void *)((uint8_t *)(M) + OFS))

    for example, some messages don't have a Cause IE. […]

    Done

• File src/libosmo-pfcp/pfcp_msg.c:

  • Patch Set #3, Line 65: struct osmo_pfcp_header_common {

    oh yes, forgot to run that script...

    Done

  • Patch Set #3, Line 338: /* Append the encoded PFCP message to the message buffer.

    It is a feature described in the PFCP specs. […]

    Done

To view, visit change 27631. To unsubscribe, or for help writing mail filters, visit settings.