Attention is currently required from: dexter, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email )
Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip
......................................................................
Patch Set 2:
(1 comment)
File src/gprs_rlcmac_sched.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/35151/comment/01b4c1fc_4c03fc14
PS1, Line 486: * way we help BTS energy saving (on TRX!=C0) by sending nothing
@fixeria bear in mind the "skip_idle &&
trx != 0" was only applied inside the #ifdef DIRECT_PHY [...]
It's getting more and more complicated, but it seems I have a more complete picture in
my mind. The `#ifdef DIRECT_PHY` block was removed in a recent patch
(I7a08d8cc670fa14f7206ffffdbc22351f3668a17), and now this patch removes the `trx != 0`
constraint.
And that was done in order to make it send stuff on C0
because those osmo-bts lowerlayers are not filling the block otherwise.
Ack. The `trx != 0` constraint was specifically needed for those DSP based models.
I realize now though, that when proposing the cleanup
in this patch, I assumed those were 1 TRX only, but lc15 has several of them right?
I am not familiar with the lc15 PHY, but AFAIR there also was a sysmoBTS model with two
TRX. Also, I don't know how those DSP based models behave when getting an empty
DATA.req for `trx!=0`. Was this ever tested?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iadb62748b18605bf158169b317f880352bc0a5a6
Gerrit-Change-Number: 35151
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Nov 2023 16:26:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment