fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email )
Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Let's address this is in a follow up patch. This
patch makes jenkins-sns.sh, equal to jenkins.sh. […]
Suggestion: maybe we could
agree on always having the latest PCUIF version configured in `osmo-ttcn3-hacks.git` (we
already do in `PCU_Tests.default`) and overwrite it here in `docker-playground.git` only
if needed (e.g. for latest or `202[0-9]q[0-9]` branches).
This way patching the config file would be as easy as doing `echo
"PCUIF_Types.mp_pcuif_version := 12" >> $1`.
--
To view, visit
https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1f94a0459e35d7b5632c81d7f7e2e60eb0d0229f
Gerrit-Change-Number: 35159
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Nov 2023 16:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment