Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email )
Change subject: ASCI: Add ASCI notification support to RR layer
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/7009c366_ea936d66
PS3, Line 1440: return -ENOMEM;
The allocation is not leaked. There is a timer running
for every notification. When it times out, the notification is removed from the list [...]
Ok, fine then! Marking as resolved.
https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/e37b4bf8_4a00ac93
PS3, Line 1519: msgb_l3len(msg) - sizeof(*nn);
There is no check. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4
Gerrit-Change-Number: 34530
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 30 Sep 2023 08:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment