Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email )
Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/ea0b0f9a_d50706cc
PS3, Line 4895: sgh = msgb_l3(msg);
No, the header is only one byte. […]
Ah, indeed.
Marking as resolved.
https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/f0a47ec1_2780820f
PS3, Line 4909: sih = msgb_l3(msg);
No, similar as above. B4 frame length is already
checked. The header is way smaller.
I overlooked the check, sorry. Marking as
resolved.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I39b27396a31137b3c4bdcb40dccdf3de60458fe2
Gerrit-Change-Number: 34529
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 30 Sep 2023 08:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment