Attention is currently required from: lynxis lazus, pespin.

laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43178?usp=email )

Change subject: RFC: sim/class_tables: add a size attribute ......................................................................

Patch Set 2:

(2 comments)

File include/osmocom/sim/class_tables.h:

https://gerrit.osmocom.org/c/libosmocore/+/43178/comment/755d966d_0c4ff760?u... : PS2, Line 39: const uint8_t *hdr); I think this breakage is serious and can't be accepted as it is used by external programs like osmo-remsim, simtrace2, possibly more. The better approach would be to add a osim_determine_apdu_case2() symbol with the new argument adn have the old one as deprecated symbol around?

https://gerrit.osmocom.org/c/libosmocore/+/43178/comment/5f80caf4_6d790fc7?u... : PS2, Line 23: i I can potentially live with that API + ABI break, as this is really AFAICT only used by library-internal helper functions