Attention is currently required from: lynxis lazus, pespin.

View Change

2 comments:

• File include/osmocom/sim/class_tables.h:

  • Patch Set #2, Line 39: const uint8_t *hdr);

    I think this breakage is serious and can't be accepted as it is used by external programs like osmo-remsim, simtrace2, possibly more. The better approach would be to add a osim_determine_apdu_case2() symbol with the new argument adn have the old one as deprecated symbol around?

  • Patch Set #2, Line 23: i

    I can potentially live with that API + ABI break, as this is really AFAICT only used by library-internal helper functions

To view, visit change 43178. To unsubscribe, or for help writing mail filters, visit settings.