Change in osmo-bts[master]: Introduce Osmux support
Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 ) Change subject: Introduce Osmux support ...................................................................... Patch Set 8: Code-Review+1 (4 comments) File configure.ac: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/27c77589_c576094e PS8, Line 81: #FIXME: ^ it actually needs > 1.2.0 looks like this can be done before merge, change ">=" to ">"? File doc/manuals/chapters/osmux_bts.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/85bbcd33_20423798 PS8, Line 3: === Osmux Support in {program-name} just curious, why use {program-name} here and below? the text below is specific to OsmoBTS, right? File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/c648dd3c_8a0d2374 PS8, Line 292: /* FIXME: not needed? YES,we probably need to iterare over : bts->osmux.osmux_handle_list and free everything there, see : osmux_handle_put() */ did you leave this intentionally / maybe not much effort to implement this instead of having the fixme? https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/ac93d25f_b2cc2f06 PS8, Line 355: were where -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 13:52:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
participants (1)
-
osmith