Attention is currently required from: pespin, dexter.

Patch set 8:Code-Review +1

View Change

4 comments:

• File configure.ac:

  • Patch Set #8, Line 81: #FIXME: ^ it actually needs > 1.2.0

    looks like this can be done before merge, change ">=" to ">"?

• File doc/manuals/chapters/osmux_bts.adoc:

  • Patch Set #8, Line 3: === Osmux Support in {program-name}

    just curious, why use {program-name} here and below? the text below is specific to OsmoBTS, right?

• File src/common/osmux.c:

  • Patch Set #8, Line 292:

    /* FIXME: not needed? YES,we probably need to iterare over
    	   bts->osmux.osmux_handle_list and free everything there, see
    	   osmux_handle_put() */
    

    did you leave this intentionally / maybe not much effort to implement this instead of having the fixme?

  • Patch Set #8, Line 355: were

    where

To view, visit change 29285. To unsubscribe, or for help writing mail filters, visit settings.