Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email ) Change subject: CSD: implement half-rate modes correctly ...................................................................... Patch Set 3: (4 comments) File include/osmo-bts/csd_v110.h: https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/dd2c453c_c9282eea?usp=... : PS2, Line 11: uint8_t ra2_ir;

It is the intermediate rate (8 or 16 kbit/s) to be used in the RA2 packing/unpacking step. I added the comment as requested.

File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/0095f1d4_b2bd47ff?usp=... : PS2, Line 1539: 2

Will do. Done

https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/ee232fef_a6e19a34?usp=... : PS2, Line 1556: else

Will do. Done

https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/94ed31f8_43fa1da6?usp=... : PS2, Line 2098: switch (lchan->tch_mode) {

Not sure if I agree - let me handle all other feedback first, then I'll get back to this one. I looked into doing what you suggested, but I like my original approach better. In the two code paths in question (one for CSD-HR UL, the other for CSD-HR DL), the only valid modes are 6.0k and 3.6k raw rates, and my code does OSMO_ASSERT on all others. Changing the code to use `csd_v110_lchan_desc[]` would entail allowing invalid modes, or more complicated error checks. Perhaps leave this part as is?

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5 Gerrit-Change-Number: 38553 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 27 Oct 2024 23:53:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon@freecalypso.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>