Attention is currently required from: fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34139 )

Change subject: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req ......................................................................

Patch Set 2:

(2 comments)

File include/l1gprs.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/34a6e4f7_d792758a PS2, Line 37: void *priv

The `priv` is already accessible via `gprs->priv`, this argument can be removed.

I really prefer passing the priv pointer as a param. This is a totally usual way of providing callbacks, and it provides the user with immedatie concern that the priv pointer is there, no need to go check if it and how it can be accessed.

https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/4f7e2ff3_34991bd9 PS2, Line 48: changed_cb

It's currently way too generic: "something has changed, figure out what exactly yourself by checking […]

I'll look into this.