Attention is currently required from: fixeria.

View Change

2 comments:

• File include/l1gprs.h:

  • Patch Set #2, Line 37: void *priv

    The `priv` is already accessible via `gprs->priv`, this argument can be removed.

    I really prefer passing the priv pointer as a param. This is a totally usual way of providing callbacks, and it provides the user with immedatie concern that the priv pointer is there, no need to go check if it and how it can be accessed.

  • Patch Set #2, Line 48: changed_cb

    It's currently way too generic: "something has changed, figure out what exactly yourself by checking […]

    I'll look into this.

To view, visit change 34139. To unsubscribe, or for help writing mail filters, visit settings.