Attention is currently required from: daniel, laforge, lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 6: Code-Review+1 (3 comments) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/52aaae31_0aae699f?usp=... : PS5, Line 587: return 1;

(personally i prefer incrementing on a separate code line, for more trivial code clarity) Agree

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/49206af8_8a9cd989?usp=... : PS5, Line 598: break;

in timeouts? yeah makes sense having an ASSERT which should hit indicating some timeout was forgotten to be added here.

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/5df43969_2a017d9b?usp=... : PS5, Line 771: /*! count times timer T timed out */

I would like to replace the words "count" and "out" with a word starting with t. […] I'm sure whatever else you put in there will be easier to read, that's really a tongue twister.

-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 28 Jan 2025 10:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>