Attention is currently required from: daniel, laforge, lynxis lazus, neels.

Patch set 6:Code-Review +1

View Change

3 comments:

• File src/libvlr/vlr_lu_fsm.c:

  • Patch Set #5, Line 587: return 1;

    (personally i prefer incrementing on a separate code line, for more trivial code clarity)

    Agree

  • Patch Set #5, Line 598: break;

    in timeouts?

    yeah makes sense having an ASSERT which should hit indicating some timeout was forgotten to be added here.

  • Patch Set #5, Line 771: /*! count times timer T timed out */

    I would like to replace the words "count" and "out" with a word starting with t. […]

    I'm sure whatever else you put in there will be easier to read, that's really a tongue twister.

To view, visit change 38490. To unsubscribe, or for help writing mail filters, visit settings.