Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28210 ) Change subject: fix rare segfault in MGCP client handling ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28210/comment/a26a33f8_7ebd1f5c PS1, Line 134: gscon_forget_mgw_endpoint_ci(conn, ci);

wouldn't it make sense to call osmo_mgcpc_ep_ci_dlcx(ci); inside gscon_forget_mgw_endpoint_ci() befo […] the dlcx() emits events that may cause FSMs to terminate and clean up (again), so we need to invalidate the reference to the ci first.

The *_forget_* is exactly about NULLing references in various places, the actual reason for NULLing should be kept apart. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If89610020f47fd6517081dd11b83911b043bd0f1 Gerrit-Change-Number: 28210 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 31 May 2022 13:10:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment