Attention is currently required from: pespin, dexter.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 )

Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ......................................................................

Patch Set 4:

(3 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/cc2531aa_8b1bc365 PS3, Line 1308: static inline bool nonamr_mand_sid_position(struct gsm_lchan *lchan,

But this particular function is not limited to FR & EFR, this one already supports TCH/H too, so it […]

In the latest patchset just uploaded, I renamed this function to fr_hr_efr_sid_position().

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/f00d59ae_c0ccc0b6 PS3, Line 1415: } else

Fair enough - I'll fix it in the next revision.

Done

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/0718334c_cef7fc42 PS3, Line 1441: if (!resp_msg && lchan->tch.dtx_fr_efr.last_rtp_input_was_sid &&

In the classic GSM architecture this logic was split between two separate components: the first part […]

In the new patchset I added a bunch of comments, extensively documenting the flow of that complex code stage by stage. Please see if it's any clearer now.