Attention is currently required from: pespin, dexter.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #3, Line 1308: static inline bool nonamr_mand_sid_position(struct gsm_lchan *lchan,

    But this particular function is not limited to FR & EFR, this one already supports TCH/H too, so it […]

    In the latest patchset just uploaded, I renamed this function to fr_hr_efr_sid_position().

  • Patch Set #3, Line 1415: } else

    Fair enough - I'll fix it in the next revision.

    Done

  • Patch Set #3, Line 1441: if (!resp_msg && lchan->tch.dtx_fr_efr.last_rtp_input_was_sid &&

    In the classic GSM architecture this logic was split between two separate components: the first part […]

    In the new patchset I added a bunch of comments, extensively documenting the flow of that complex code stage by stage. Please see if it's any clearer now.

To view, visit change 32714. To unsubscribe, or for help writing mail filters, visit settings.