Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: enforce optional data length limits ...................................................................... Patch Set 4: Code-Review-1 (5 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/06c69059_3b261ef1 PS4, Line 7: SIGTRAN: enforce optional data length limits "enforce length limits on SCCP Optional Data" ? File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/c270a568_6601112b PS4, Line 580: if (prim && msgb_l2(prim->oph.msg) && msgb_l2len(prim->oph.msg)) { exit early if (!(...)) return true; if (msgb...) { ... } xua_msg_add_data(...); return true; https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/3dbb9804_bdfbc6b7 PS4, Line 585: xua_msg_free(xua); freeing here is very confusing memory management. The caller should do this free when receiving an error rc. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d876a623_fb00d419 PS4, Line 615: if (!xua_add_data(prim, xua, "4.2")) this looks like a mem leak of above xua_msg_alloc(). the free should not be in xua_add_data() https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/0191abbb_68985a90 PS4, Line 617: /* optional: hop coun */ "count" ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment