Attention is currently required from: msuraev.

Patch set 4:Code-Review -1

View Change

5 comments:

• Commit Message:

  • Patch Set #4, Line 7: SIGTRAN: enforce optional data length limits

    "enforce length limits on SCCP Optional Data" ?

• File src/sccp_scoc.c:

  • Patch Set #4, Line 580: if (prim && msgb_l2(prim->oph.msg) && msgb_l2len(prim->oph.msg)) {

    exit early

      if (!(...))
          return true;
      if (msgb...) {
         ...
      }
      xua_msg_add_data(...);
      return true;

  • Patch Set #4, Line 585: xua_msg_free(xua);

    freeing here is very confusing memory management. The caller should do this free when receiving an error rc.

  • Patch Set #4, Line 615: if (!xua_add_data(prim, xua, "4.2"))

    this looks like a mem leak of above xua_msg_alloc().
    the free should not be in xua_add_data()

  • Patch Set #4, Line 617: /* optional: hop coun */

    "count" ?

To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.