Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31547
)
Change subject: bssmap_handle_ass_req_ct_data: implement
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/bsc/codec_pref.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/11f056ba_ca4c80b7
PS1, Line 22: const bool full_rate);
I wonder why is enum rate_pref rate_pref not used
here.
Because it is not possible to use RATE_PREF_NONE here, so it's a boolean.
Do you think it makes more sense to use enum rate_pref regardless of this?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31547
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I350bea15fd2158eb6edc9bc92f2dca48930736e9
Gerrit-Change-Number: 31547
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 11:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment