Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31544
)
Change subject: codec_pref: split test_codec_support_bts_rate
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/codec_pref.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31544/comment/5547a57d_616f3fec
PS1, Line 211: if (rc < 0 || !test_codec_support_bts_rate(bts, full_rate))
this looks a bit weird/condensed, you could split it
into 2 ifs like it was before.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31544
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iea8a23ef3c66ed556110038fe9f3bc7f6eef3e96
Gerrit-Change-Number: 31544
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 11:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment